You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that you can view the thumbnail image in the chat.
Tap on the image, and verify that you can view the full-size preview in the attachment modal.
Make sure you are not logged into E.com.
Upload a .zip file to chat.
Click on the attachment link for the .zip file, verify that it is downloaded without logging into E.com.
Log out then back in, then repeat steps 2, 3, & 6
Open the developer console, go to Application, search for the session key, and erase the key-value pair for encryptedAuthToken. Then refresh the page and repeat steps 2, 3, & 6.
In case it is different problem than you have. The branch should probably not work yet as mentioned above, but for me it keeps hanging on blank page after uploading an image. The thumbnail was loading for a long time so I refreshed the page and I get a blank blue page and the only way to make it work is to Clear site data in the inspector.
for me it keeps hanging on blank page after uploading an image
Good call out @mountiny, thanks for testing! This helped me identify a bug in the migration, which is now fixed. For posterity, the two issues here were:
(Web-E) The encryptedAuthToken needed to be url-encoded before being sent across the network.
I was missing a resolve() in the migration so the promise was hanging.
@mountiny Good question – general rule-of-thumb is don't merge a PR with HOLD in the title. In this case we need to wait for that Web-E PR to be deployed to production.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roryabraham
changed the title
Details
Uses an encrypted auth token instead of a plain one in URLs to fetch images.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/166503
Tests / QA Steps
.zipfile to chat..zipfile, verify that it is downloaded without logging into E.com.sessionkey, and erase the key-value pair forencryptedAuthToken. Then refresh the page and repeat steps 2, 3, & 6.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android